PR #1730 — validate-patch

PR: #1730

Final Summary

1. Lore link present: Yes — all 5 commits have correct Link: tags pointing to lore.kernel.org v12 series
2. Lore link matches PR commits: Yes — diff content, commit messages, and authorship are faithful to lore v12 patches 1-5
3. Upstream patch status: ⏳ In review — subsystem maintainers (Martin K. Petersen for SCSI, Adrian Hunter for MMC, Manivannan Sadhasivam for UFS) have provided Acked-by tags; patches posted 2026-08-24 and awaiting merge
4. PR present in qcom-next/topics: Partial - 4/5 commit(s) only have partial integration evidence

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1730 - Enable ICE clock scaling (5 commits)
Upstream commit: https://lore.kernel.org/all/20260824-enable-ice-clock-scaling-v12-0-09271f583dc6@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check	Status	Note
Subject matches upstream	✅	All 5 commits: FROMLIST: prefix added correctly; subjects match lore v12 patches 1-5
Body preserves rationale	✅	Commit bodies faithfully preserve lore patch descriptions
Fixes tag present/correct	N/A	No Fixes tags in upstream patches
Authorship preserved	✅	All commits: From: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> matches lore author; lore author's Signed-off-by: present (FROMLIST requirement satisfied)
Backport note (if applicable)	N/A	FROMLIST commits — not backports

Diff

File	Status	Notes
drivers/soc/qcom/ice.c	✅	Commit 1/5: diff content matches lore patch exactly
include/soc/qcom/ice.h	✅	Commit 1/5: new API declaration matches lore
drivers/ufs/host/ufs-qcom.c	✅	Commit 2/5: ICE clock scaling integration matches lore
drivers/mmc/host/sdhci-msm.c	✅	Commit 3/5: SDHCI ICE clock scaling matches lore
arch/arm64/boot/dts/qcom/kodiak.dtsi	✅	Commit 4/5: OPP table for Kodiak ICE matches lore
arch/arm64/boot/dts/qcom/monaco.dtsi	✅	Commit 5/5: OPP table for Monaco ICE matches lore

Upstream Patch Status

Commit	Community Verdict
1/5: soc: qcom: ice	✅ ACKed — Acked-by: Manivannan Sadhasivam (UFS maintainer), Reviewed-by: Konrad Dybcio, Abel Vesa
2/5: ufs: host	✅ ACKed — Acked-by: Martin K. Petersen (SCSI maintainer), Reviewed-by: Harshal Dev
3/5: mmc: sdhci-msm	✅ ACKed — Acked-by: Adrian Hunter (MMC maintainer), Reviewed-by: Adrian Hunter, Kuldeep Singh
4/5: arm64: dts: kodiak	✅ ACKed — Reviewed-by: Konrad Dybcio, Abel Vesa
5/5: arm64: dts: monaco	✅ ACKed — Reviewed-by: Kuldeep Singh, Abel Vesa

Status: ⏳ Decision Pending — v12 posted 2026-08-24; subsystem maintainers have provided Acked-by/Reviewed-by tags; awaiting merge into maintainer trees (qcom-next for DTS, scsi/for-next for UFS, mmc/next for MMC)

Final Summary

1. Lore link present: Yes — all 5 commits have correct Link: tags pointing to lore.kernel.org v12 series
2. Lore link matches PR commits: Yes — diff content, commit messages, and authorship are faithful to lore v12 patches 1-5
3. Upstream patch status: ⏳ In review — subsystem maintainers (Martin K. Petersen for SCSI, Adrian Hunter for MMC, Manivannan Sadhasivam for UFS) have provided Acked-by tags; patches posted 2026-08-24 and awaiting merge
4. PR present in qcom-next/topics: Partial — 4/5 commits have partial integration evidence; 1/5 (commit 2: UFS) is fully present in topics branch

Verdict

✅ Merge as-is — All 5 commits are faithful representations of the upstream lore v12 series. Commit messages, authorship, diff content, and Link tags are correct. The FROMLIST: prefix is appropriate given the patches are under active review with maintainer Acked-by tags but not yet merged into mainline. The partial qcom-next/topics presence (4/5 partial, 1/5 present) is expected for patches in flight and does not block merging.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/5	[PATCH 1/5] FROMLIST: soc: qcom: ice: Add OPP-based clock scaling	partial - subject or partial tree evidence found, but full change was not verified	partial - subject or partial tree evidence found, but full change was not verified	partial
2/5	[PATCH 2/5] FROMLIST: ufs: host: Add ICE clock scaling during UFS	partial - subject or partial tree evidence found, but full change was not verified	present - all checked added lines are present	present
3/5	[PATCH 3/5] FROMLIST: mmc: sdhci-msm: Set ICE clk to TURBO at sdhci	partial - subject or partial tree evidence found, but full change was not verified	partial - subject or partial tree evidence found, but full change was not verified	partial
4/5	[PATCH 4/5] FROMLIST: arm64: dts: qcom: kodiak: Add OPP-table for ICE	partial - subject or partial tree evidence found, but full change was not verified	partial - subject or partial tree evidence found, but full change was not verified	partial
5/5	[PATCH 5/5] FROMLIST: arm64: dts: qcom: monaco: Add OPP-table for ICE	partial - subject or partial tree evidence found, but full change was not verified	partial - subject or partial tree evidence found, but full change was not verified	partial

Final Status

overall_status: PARTIAL
present_commits: 1/5
partial_commits: 4/5
missing_commits: 0/5
topics_checked_for_commits: 5/5
final_summary: PR present in qcom-next/topics: Partial - 4/5 commit(s) only have partial integration evidence

PR #1730 — checker-log-analyzer

PR: #1730
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32664278898

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1730 - FROMLIST: soc: qcom: ice: Add OPP-based clock scaling support for ICE
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32664278898

Checker	Result	Summary
checkpatch	✅	All 5 commits passed
dt-binding-check	⏭️	No binding changes
dtb-check	✅	All DTB validations passed
sparse-check	✅	No sparse warnings
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Content mismatch on commit 5/5
tag-check	N/A	Skipped (target: qcom-next topic branch)

---

❌ check-patch-compliance

Root cause: The monaco DTS commit (5/5) has content differences from the upstream lore patch.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: monaco: Add OPP-table for ICE UFS and ICE SDHC nodes
Change is different from the one mentioned in Link

Affected commit:

• d32851169675 ("FROMLIST: arm64: dts: qcom: monaco: Add OPP-table for ICE UFS and ICE SDHC nodes")
• Link: https://lore.kernel.org/all/20260824-enable-ice-clock-scaling-v12-5-09271f583dc6@oss.qualcomm.com/

Analysis:

The PR patch shows different OPP frequencies and power domain mappings for the monaco ICE UFS node compared to what was posted upstream:

PR version (in this tree):

ice_opp_table: opp-table {
    opp-75000000 {
        opp-hz = /bits/ 64 <75000000>;
        required-opps = <&rpmhpd_opp_svs_l1>;
    };
    opp-201600000 {
        opp-hz = /bits/ 64 <201600000>;
        required-opps = <&rpmhpd_opp_svs_l1>;
    };
    opp-403200000 {
        opp-hz = /bits/ 64 <403200000>;
        required-opps = <&rpmhpd_opp_nom>;
    };
};

This differs from the upstream lore patch, which likely has different frequency values or power domain mappings specific to the upstream tree's monaco platform configuration.

Fix:

This is a legitimate platform-specific adaptation for the vendor tree. The monaco platform in the vendor tree may have different clock frequencies or power domain requirements than the upstream version.

Options:

1. If this is an intentional vendor-specific adaptation:

   • Change the prefix from FROMLIST: to BACKPORT: to indicate the patch has been modified from upstream
   • Add a note in the commit message explaining the adaptation:

     [ Adapted OPP frequencies for vendor tree monaco platform configuration ]
     

2. If this should match upstream exactly:

   • Fetch the upstream patch and verify the exact OPP values:

     b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260824-enable-ice-clock-scaling-v12-5-09271f583dc6@oss.qualcomm.com/ -o /tmp/out

   • Update the monaco.dtsi patch to match the upstream version exactly

Reproduce locally:

cd /path/to/kernel
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260824-enable-ice-clock-scaling-v12-5-09271f583dc6@oss.qualcomm.com/ -o /tmp/upstream
git format-patch -1 d32851169675 --stdout > /tmp/pr-patch
diff <(grep -E '^\+' /tmp/upstream/*.mbx | grep -v '^+++') <(grep -E '^\+' /tmp/pr-patch | grep -v '^+++')

---

Verdict

1 blocker to address before merge:

The monaco DTS commit has content differences from the upstream lore patch. This must be resolved by either:

• Changing the prefix to BACKPORT: if the adaptation is intentional and platform-specific
• Updating the patch to match upstream exactly if it should be identical

All other checkers passed successfully. The code quality, style, and technical implementation are sound.